Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option to skip homescreen check #305

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Add option to skip homescreen check #305

merged 1 commit into from
Jun 14, 2020

Conversation

fronzbot
Copy link
Owner

Description:

Add option at Blink instantiation to skip checking for owl entries (blink mini cameras)

blink = Blink(no_owls=True)

Saves an uneccessary API call and maybe fixes 24hr repeated request for 2fa key.

Related issue (if applicable): #279

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #305 into dev will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #305      +/-   ##
==========================================
+ Coverage   82.80%   82.88%   +0.07%     
==========================================
  Files           8        8              
  Lines         919      923       +4     
==========================================
+ Hits          761      765       +4     
  Misses        158      158              
Flag Coverage Δ
#unittests 82.88% <100.00%> (+0.07%) ⬆️
Impacted Files Coverage Δ
blinkpy/blinkpy.py 79.81% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382db80...d9e3761. Read the comment docs.

@fronzbot fronzbot merged commit 1765584 into dev Jun 14, 2020
@fronzbot fronzbot deleted the disable-owl-option branch June 14, 2020 02:08
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant